Skip to content

Send different decoded MID event types to different specs#6930

Merged
shahor02 merged 3 commits into
AliceO2Group:devfrom
dstocco:splitevents
Sep 6, 2021
Merged

Send different decoded MID event types to different specs#6930
shahor02 merged 3 commits into
AliceO2Group:devfrom
dstocco:splitevents

Conversation

@dstocco
Copy link
Copy Markdown
Contributor

@dstocco dstocco commented Aug 30, 2021

During data taking MID receives software calibration triggers that are used to test noisy channels.
Few BCs after the reception of the calibration trigger, the MID returns a special event (Front-End-Test event) where all channels should anwer.
These events are used to test the dead channels.
These events are not reconstructed like the physics event, but are sent to separate workflows and used to generate masks.
Since they're not used in the standard reconstruction, they will be streamed on different specs to simplify operations.

The commits are meant to be atomic. Please do not squash.

@dstocco dstocco requested review from a team and aphecetche as code owners August 30, 2021 13:47
@dstocco dstocco force-pushed the splitevents branch 2 times, most recently from 494d971 to 7dd6888 Compare August 31, 2021 12:01
@dstocco
Copy link
Copy Markdown
Contributor Author

dstocco commented Sep 1, 2021

Hi @aphecetche ,
the error is not on O2 but QualityControl. I've renamed a file which is used in QualityControl. Actually, I took care of removing the conflicting part from the QualityControl master branch before doing the O2 PR:
AliceO2Group/QualityControl#817
But it seems that the CI does not compile the QualityControl master, but rather a tag...
I can assure you that this PR does not break the QualityControl master, but of course it will fail on old tags.

@aphecetche
Copy link
Copy Markdown
Collaborator

@dstocco I guess the idea then would be to ask for a QC tag, right @Barthelemy ?

@dstocco
Copy link
Copy Markdown
Contributor Author

dstocco commented Sep 1, 2021

Well, I see that the v1.28 was produced yesterday. So I guess it's just a matter of moving to the new tag in the CI...

@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Sep 1, 2021

@dstocco you can also put back the old file, and then remove it when the QC will have correct version.

@dstocco
Copy link
Copy Markdown
Contributor Author

dstocco commented Sep 1, 2021

@shahor02 : good point, I've just done it

@aphecetche
Copy link
Copy Markdown
Collaborator

@shahor02 can this one be merged ? thanks.

@shahor02 shahor02 merged commit 3dc34a1 into AliceO2Group:dev Sep 6, 2021
@dstocco dstocco deleted the splitevents branch September 6, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants